Merged
Conversation
The border and background were removed in 5d004c1, but not all the CSS was.
This is the same border-radius that's always set on that ID: https://github.com/rust-lang/rust/blob/a9d1cafa878ecc04a4aa7aaa7df0414a29a2bd0b/src/librustdoc/html/static/css/rustdoc.css#L825-L836
…notriddle Use named arguments to make GUI test more clear As you suggested `@notriddle.` The result looks like this. r? `@notriddle`
…ll, r=GuillaumeGomez rustdoc: factor JS mobile scroll lock into its own function rust-lang#98775 (comment)
…ings-help-button, r=GuillaumeGomez rustdoc: remove redundant CSS on `#copy-path` The border and background were removed in 5d004c1, but not all the CSS was.
…r=GuillaumeGomez
rustdoc: remove redundant CSS `#crate-search { border-radius }`
This is the same border-radius that's always set on that ID:
https://github.com/rust-lang/rust/blob/a9d1cafa878ecc04a4aa7aaa7df0414a29a2bd0b/src/librustdoc/html/static/css/rustdoc.css#L825-L836
rustbot
added
T-infra
Member
Author
|
@bors r+ rollup=never p=4 |
Collaborator
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 06f049a355 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (194140b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#copy-path#103161 (rustdoc: remove redundant CSS on#copy-path)#crate-search { border-radius }#103162 (rustdoc: remove redundant CSS#crate-search { border-radius })Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup